Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container test runs for RISC-V #20223

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

grisu48
Copy link
Contributor

@grisu48 grisu48 commented Sep 19, 2024

Update container URLs to make the container test runs work on RISC-V.

@grisu48 grisu48 added the WIP Work in progress label Sep 19, 2024
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@grisu48 grisu48 force-pushed the riscv branch 2 times, most recently from 98b056b to 7ab60e0 Compare October 3, 2024 13:01
@grisu48 grisu48 removed the WIP Work in progress label Oct 9, 2024
@grisu48 grisu48 changed the title WIP: Add container test runs for RISC-V Add container test runs for RISC-V Oct 9, 2024
@grisu48 grisu48 marked this pull request as ready for review October 9, 2024 11:42
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@@ -94,8 +94,11 @@ sub run {
record_info('Compare images', 'Both extracted copies must be identical.');
assert_script_run("diff -urN $dir1 $dir2", fail_message => 'Copied images are not identical.');

# Skipped on RISC-V until a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until a ...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Until a registry image is available".

Then I figured out that on registry.opensuse.org there is one available, so there is no unless in the code and this comment should have been removed 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(leftover comment, I removed it)

Update container URLs to make the container test runs work on RISC-V
Tumbleweed.
@mloviska mloviska merged commit a7f1bbe into os-autoinst:master Oct 10, 2024
10 checks passed
@grisu48 grisu48 deleted the riscv branch October 10, 2024 07:09
@DimStar77
Copy link
Contributor

This PR seems the one responsible to break all docker_privileged_mode test runs:

image

investigation runs on e.g. https://openqa.opensuse.org/tests/4551334#comments help support the thesis, that we are looking at a test change (and this PR somewhat seems like the only one touching the areas of containers; the VR referenced for x86_64 was only running the podman tests, but excluded the docker tests)

@DimStar77
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants