-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container test runs for RISC-V #20223
Conversation
bde4693
to
4d83456
Compare
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
98b056b
to
7ab60e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
tests/containers/skopeo.pm
Outdated
@@ -94,8 +94,11 @@ sub run { | |||
record_info('Compare images', 'Both extracted copies must be identical.'); | |||
assert_script_run("diff -urN $dir1 $dir2", fail_message => 'Copied images are not identical.'); | |||
|
|||
# Skipped on RISC-V until a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until a ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Until a registry image is available".
Then I figured out that on registry.opensuse.org there is one available, so there is no unless
in the code and this comment should have been removed 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(leftover comment, I removed it)
Update container URLs to make the container test runs work on RISC-V Tumbleweed.
This PR seems the one responsible to break all docker_privileged_mode test runs: investigation runs on e.g. https://openqa.opensuse.org/tests/4551334#comments help support the thesis, that we are looking at a test change (and this PR somewhat seems like the only one touching the areas of containers; the VR referenced for x86_64 was only running the podman tests, but excluded the docker tests) |
Update container URLs to make the container test runs work on RISC-V.